fix(Calendar month) aria labels for dates outside of the selected month are inaccurate#7720
Conversation
|
Preview: https://patternfly-react-pr-7720.surge.sh A11y report: https://patternfly-react-pr-7720-a11y.surge.sh |
|
@dominik-petrik this PR needs to be rebased after your CalendarMonth PR gets merged before we can merge this - since you accidentally included your calendarmonth improvements in this PR. |
thatblindgeye
left a comment
There was a problem hiding this comment.
The update for the aria-labels looks (and sounds) good! Once your other PR gets merged and this gets rebased like Nicole said I can approve 🙂
wise-king-sullyman
left a comment
There was a problem hiding this comment.
This change looks good! Can you add a test for this as well?
Sure thing! |
7d7e890 to
6e9fd10
Compare
6e9fd10 to
89a18ce
Compare
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Looks great! Thanks for your quick work on this 🚀
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
…th are inaccurate (patternfly#7720) * fix(CalendarMonth) add tests * fix(CalendarMonth) update tests
What: Closes #7718
There was same issue with years in aria label. 31 December 2023 date had "31 January 2024" aria label. This should be also resolved by this pull request.